Crop extension #1666
Merged
Crop extension #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization)
* cleanup build and test scripts
|
@dotnet-bot test this please |
|
This doesn't look correct - something seems wrong with your git repo. I assume you should rebase this on origin/master and hard rest your master on origin/master |
|
Yes but without proper rebase and hard resets they will always come back... |
|
@forki Yes. Though it's not that bad - the use of squash-and-merge means that they don't enter the commit history (though they keep appearing in the squash-merge messages unless they get edited out) |
|
True squashing is a way to keep these hashes out. But I vote to require everyone to fix up their history in order to have proper diff here on github. It's just super hard to review with broken history. |
|
approved (with squash :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for cropextension to reduce the number of times it calls validate path character.
Also contains revert nunit.consolerunner to 3.0.0